You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/18 17:03:34 UTC

[GitHub] [spark] viirya edited a comment on pull request #32221: [SPARK-35125][K8S] Upgrade K8s client to 5.3.0 to support K8s 1.20

viirya edited a comment on pull request #32221:
URL: https://github.com/apache/spark/pull/32221#issuecomment-822023718


   Good point @attilapiros. But maybe we should implement both argumentless and `onClose(WatcherException cause)`? At least I think we should log the exception like currently we did.
   
   Actually if we don't have cleanup operation to do, maybe we don't need to override argumentless one?
   
   > For example here I think the argumentless version should be used instead:
   > 
   > https://github.com/apache/spark/blob/a902250e4a6cc88d20097ab356884bc2813edba3/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala#L61-L65
   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org