[jira] [Updated] (PROTON-99) Porting Issue -- pn_dtag macro does not compile with Visual Studio compiler

["Mary hinton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PROTON-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mary hinton updated PROTON-99:
------------------------------

    Attachment: pn_dtag.patch

This patch can also be viewed at github in branch protonWin
 
PROTON-99 changed pn_dtag macro to a function 
 
https://github.com/MaryDHinton/qpid-proton/compare/protonWin
                
> Porting Issue -- pn_dtag macro does not compile with Visual Studio compiler
> ---------------------------------------------------------------------------
>
>                 Key: PROTON-99
>                 URL: https://issues.apache.org/jira/browse/PROTON-99
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>         Environment: Windows using Visual Studio 2010 
>            Reporter: Mary hinton
>              Labels: build
>         Attachments: pn_dtag.patch
>
>
> I would like to replace the pn_dtag macro with a function that will compile using either GNU or  Visual Studio compilers.
> engine.h
> Replace:
> #define pn_dtag(BYTES, SIZE) ((pn_delivery_tag_t) {(SIZE), (BYTES)}
> With:
> pn_delivery_tag_t pn_dtag(const char *bytes, size_t size);
> engine.c
> Add:
> pn_delivery_tag_t pn_dtag(const char *bytes, size_t size) 
> {
>   pn_delivery_tag_t delivt;
>   delivt.bytes = bytes;
>   delivt.size = size;
>   return delivt;
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira