You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Craig McClanahan <cr...@gmail.com> on 2013/04/02 19:04:22 UTC
Drag and Drop on Widget Layout Page
Is drag and drop supposed to be working? I tried the following on both
Chrome and Firefox, and see:
* Create a new page using the wide+narrow layout
* Add an activity stream widget (goes into the left column)
* Add a different widget (in my case, the Google News one), also went into
left column
* Tried to drag the Google News widget to the right column
* Saw a very shortened rectangle in the right, and garbled text in the left.
This is with Rave trunk code from over the weekend.
Craig
Re: Drag and Drop on Widget Layout Page
Posted by Erin Noe-Payne <er...@gmail.com>.
Cool. Glad it's working - not a problem. =)
On Tue, Apr 2, 2013 at 5:33 PM, Craig McClanahan <cr...@apache.org> wrote:
> Of course, now that I watch it, it works :-). You have to drag it far
> enough for the left edge to be in the new area. Sorry for the noise.
>
> For the record, this was on Firefox 19.0.2 on Ubuntu 12.04.
>
> Craig
Re: Drag and Drop on Widget Layout Page
Posted by Craig McClanahan <cr...@apache.org>.
Of course, now that I watch it, it works :-). You have to drag it far
enough for the left edge to be in the new area. Sorry for the noise.
For the record, this was on Firefox 19.0.2 on Ubuntu 12.04.
Craig
Re: Drag and Drop on Widget Layout Page
Posted by Erin Noe-Payne <er...@gmail.com>.
I am not able to reproduce running Firefox 20.0. Drag and drop appears
to be working fine for me.
- The errors that end with "Declaration dropped" are all related to
css. They can be safely ignored, and I believe firefox gives you a
filter button to hide them.
- The rave_api errors are coming from the functions for saving gadget
preferences. That shouldn't be getting invoked from drag and drop. Is
there a stack trace available for those errors?
On Tue, Apr 2, 2013 at 3:58 PM, Craig McClanahan <cr...@apache.org> wrote:
> On Tue, Apr 2, 2013 at 11:36 AM, Erin Noe-Payne <er...@gmail.com>
> wrote:
>>
>> Hmm. This is the call that I removed with my most recent update.
>> Taking a look at the file in source [1] the text
>> 'extractObjectIdFromElementId' isn't there at all. I don't svn well
>> enough - but is there any reason that you may not be receiving the
>> latest source from trunk?
>>
>> [1]
>> http://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/static/script/portal/rave_ui.js
>>
>
> I am indeed checking out trunk, and I see your patch to rave_ui.js (revision
> 1463354) from yesterday, which changed "extract" to "get" in both lines 258
> and 259. I wonder if my browser is caching the old versions ... yep, it
> was.
>
> OK, clearing cache changed the behavior. In Chrome, the move now works. In
> FF, you can see it try to move, but it gets put back with the following
> errors in the error console:
>
> Error in parsing value for 'padding-bottom'. Declaration dropped
> (http://localhost:8080/portal/app/page/view/2)
> Error in parsing value for 'padding-bottom'. Declaration dropped
> (http://localhost:8080/portal/app/page/view/2)
> Error in parsing value for 'filter'. Declaration dropped (
> Timestamp: 13-04-02 12:44:27 PM
> Warning: Error in parsing value for 'filter'. Declaration dropped.
> Source File:
> http://localhost:8080/gadgets/ifr?url=http%3A%2F%2Fwww.gstatic.com%2Fig%2Fmodules%2Ftabnews%2Ftabnews.xml&container=default&view=default&lang=en&country=US&debug=1&nocache=1&sanitize=%25sanitize%25&v=585f108ca6f792202c2f07bf69917790&st=default%3A5EINYW-KANRxMl6eCQIGGhON1a4AFRUxnKyRFW4cTvwad3ZXYFqHhXm8lbPxUQcmNQKIAddpKis8tHhg1IREbQT2JFy94AyZaUe-Sf3a-3N7DKm5gp4OWmaLjUAxplD04yB6-QZ1mKlUNjO4ZTObSJPg5NIl8gkdOg6t9_nl4NbwOvloZSahI52DnutlW8nVUvbElwMzi03uc6D8__Gub3puk1M&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0#up_ned=&up_items=5&up_show_image=0&up_font_size=13pt&up_queryList=&up_selectedTab=0&up_tabs=&up_last_url=&up_onebox=&rpctoken=508590011
> TypeError: args.userPref is undefined
> (http://localhost:8080/static/script/core/rave_api.js)
> TypeError: args.userPref is undefined
> (http://localhost:8080/static/script/core/rave_api.js)
>
> The latter two errors are coming from line 60 of rave_api.js.
>
> Craig
>
Re: Drag and Drop on Widget Layout Page
Posted by Craig McClanahan <cr...@apache.org>.
On Tue, Apr 2, 2013 at 10:25 AM, Erin Noe-Payne <er...@gmail.com>wrote:
> There was a bug in drag and drop, the fix was committed yesterday.
> Update your source and let me know if your issue persists.
>
> Just updated and still fails (Chrome+Linux, Firefox+Linux). The only
difference is that in FF, the box on the right is short. In both cases,
the hand cursor is still active.
Attached is a screen shot of the Chrome window after I've tried to drag the
Google News Gadget to the right.
Craig
Re: Drag and Drop on Widget Layout Page
Posted by Erin Noe-Payne <er...@gmail.com>.
There was a bug in drag and drop, the fix was committed yesterday.
Update your source and let me know if your issue persists.
On Tue, Apr 2, 2013 at 1:04 PM, Craig McClanahan <cr...@gmail.com> wrote:
> Is drag and drop supposed to be working? I tried the following on both
> Chrome and Firefox, and see:
> * Create a new page using the wide+narrow layout
> * Add an activity stream widget (goes into the left column)
> * Add a different widget (in my case, the Google News one), also went into
> left column
> * Tried to drag the Google News widget to the right column
> * Saw a very shortened rectangle in the right, and garbled text in the left.
>
> This is with Rave trunk code from over the weekend.
>
> Craig