You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/05/07 06:39:47 UTC

Review Request 33927: HIVE-10639 create SHA1 UDF

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33927/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Bugs: HIVE-10639
    https://issues.apache.org/jira/browse/HIVE-10639


Repository: hive-git


Description
-------

HIVE-10639 create SHA1 UDF


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSha1.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSha1.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_sha1.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 
  ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/33927/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 33927: HIVE-10639 create SHA1 UDF

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33927/
-----------------------------------------------------------

(Updated May 12, 2015, 10:11 p.m.)


Review request for hive and Jason Dere.


Changes
-------

patch#3 use Text.getBytes() instead of toString()


Bugs: HIVE-10639
    https://issues.apache.org/jira/browse/HIVE-10639


Repository: hive-git


Description
-------

HIVE-10639 create SHA1 UDF


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSha1.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSha1.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_sha1.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 
  ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/33927/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 33927: HIVE-10639 create SHA1 UDF

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33927/
-----------------------------------------------------------

(Updated May 8, 2015, 5:33 p.m.)


Review request for hive and Jason Dere.


Changes
-------

performance optimization. removed unnecessary copyBytes operation.


Bugs: HIVE-10639
    https://issues.apache.org/jira/browse/HIVE-10639


Repository: hive-git


Description
-------

HIVE-10639 create SHA1 UDF


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 02a604ff0a4ed92dfd94b199e8b539f636b66f77 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSha1.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFSha1.java PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_sha1.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out a422760400c62d026324dd667e4a632bfbe01b82 
  ql/src/test/results/clientpositive/udf_sha1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/33927/diff/


Testing
-------


Thanks,

Alexander Pivovarov