You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/14 07:21:01 UTC
[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #119: fix: update widget name rules and the association selector options
Fine0830 opened a new pull request, #119:
URL: https://github.com/apache/skywalking-booster-ui/pull/119
Fixes widget name rules and the association selector.
Video
https://user-images.githubusercontent.com/20871783/178924901-99af3957-cdb0-403c-8cb4-af937d7cd917.mov
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #119: fix: update widget name rules and the association selector options
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #119:
URL: https://github.com/apache/skywalking-booster-ui/pull/119#discussion_r920859689
##########
src/locales/lang/en.ts:
##########
@@ -145,7 +145,7 @@ const msg = {
associateOptions: "Association Options",
widget: "Widget",
nameTip:
- "The name only supports Chinese and English, horizontal lines and underscores",
+ "The name only supports Chinese and English, horizontal lines and underscores and is limited to 300 characters",
Review Comment:
```suggestion
"The name only supports Chinese and English, horizontal lines and underscores. The length of the name is limited to 300 characters",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #119: fix: update widget name rules and the association selector options
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #119:
URL: https://github.com/apache/skywalking-booster-ui/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #119: fix: update widget name rules and the association selector options
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #119:
URL: https://github.com/apache/skywalking-booster-ui/pull/119#discussion_r920860249
##########
src/locales/lang/en.ts:
##########
@@ -145,7 +145,7 @@ const msg = {
associateOptions: "Association Options",
widget: "Widget",
nameTip:
- "The name only supports Chinese and English, horizontal lines and underscores",
+ "The name only supports Chinese and English, horizontal lines and underscores and is limited to 300 characters",
Review Comment:
Please update Spanish version accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org