You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2022/03/11 07:15:17 UTC

[GitHub] [poi] appbakers opened a new pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

appbakers opened a new pull request #312:
URL: https://github.com/apache/poi/pull/312


   Please check code change.
   If there is a reason why close is not called after underlying XSSFWorkbook is written.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning commented on pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

Posted by GitBox <gi...@apache.org>.
pjfanning commented on pull request #312:
URL: https://github.com/apache/poi/pull/312#issuecomment-1064841771


   That code change was deliberate as far as I know. Could you change your code to close the SXSSFWorkbook and also to call dispose on the SXSSFWorkbook after you do the write?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] pjfanning edited a comment on pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

Posted by GitBox <gi...@apache.org>.
pjfanning edited a comment on pull request #312:
URL: https://github.com/apache/poi/pull/312#issuecomment-1064841771


   That code change was deliberate as far as I know. Could you change your code to close the SXSSFWorkbook and also to call dispose on the SXSSFWorkbook after you do the write?
   
   This seems to be related to https://bz.apache.org/bugzilla/show_bug.cgi?id=65949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] appbakers commented on pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

Posted by GitBox <gi...@apache.org>.
appbakers commented on pull request #312:
URL: https://github.com/apache/poi/pull/312#issuecomment-1064845015


   Okay. It seems deliberate. I found error while executing poi test after this change.
   
   so the close should not called inside SXSSFWorkbook.write() method.
   
   I am closing this request.
   
   > Task :poi-ooxml:test
   
   TestSXSSFWorkbook > bug53515() FAILED
       org.opentest4j.AssertionFailedError at TestSXSSFWorkbook.java:354                                                                  
           Caused by: java.io.IOException at TestSXSSFWorkbook.java:354
   
   TestSXSSFBugs > bug60197_NamedRangesReferToCorrectSheetWhenSheetOrderIsChanged() FAILED                           
       java.lang.RuntimeException at SXSSFITestDataProvider.java:76
           Caused by: java.io.IOException at POIXMLDocument.java:215
   
   TestSXSSFBugs > testWriteDocumentTwice() FAILED
       java.io.IOException at POIXMLDocument.java:215
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[GitHub] [poi] appbakers closed pull request #312: close XSSFWorkbook on SXSSFWorkbook.write() method

Posted by GitBox <gi...@apache.org>.
appbakers closed pull request #312:
URL: https://github.com/apache/poi/pull/312


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org