You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/11/23 19:02:19 UTC
[jira] Created: (MNG-3866) Plugin definitions from child and parent
are not merged when version differs
Plugin definitions from child and parent are not merged when version differs
----------------------------------------------------------------------------
Key: MNG-3866
URL: http://jira.codehaus.org/browse/MNG-3866
Project: Maven 2
Issue Type: Bug
Components: Inheritance and Interpolation
Affects Versions: 3.0-alpha-1
Reporter: Benjamin Bentmann
Parent POM snippet
{code:xml}
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-configuration</artifactId>
<!-- Note missing version element -->
<configuration>
<stringParam>PASSED</stringParam>
</configuration>
</plugin>
</plugins>
{code}
Child POM snippet:
{code:xml}
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-configuration</artifactId>
<version>2.1-SNAPSHOT</version>
</plugin>
</plugins>
{code}
Effective child POM:
{code:xml}
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-configuration</artifactId>
<version>2.1-SNAPSHOT</version>
</plugin>
</plugins>
{code}
i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3866) [regression] Plugin definitions from
child and parent are not merged when version differs
Posted by "Shane Isbell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160370#action_160370 ]
Shane Isbell commented on MNG-3866:
-----------------------------------
3.x behavior seems correct to me. If there are different versions of plugins, it is a bit dangerous to start mixing the plugin configurations.
> [regression] Plugin definitions from child and parent are not merged when version differs
> -----------------------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) Plugin definitions from child and parent
are not merged when version differs
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3866:
-----------------------------------
Attachment: plugin-model-container.patch
> Plugin definitions from child and parent are not merged when version differs
> ----------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) Plugin definitions from child and parent
are not merged when version differs
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3866:
-----------------------------------
Attachment: (was: plugin-model-container.patch)
> Plugin definitions from child and parent are not merged when version differs
> ----------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) Plugin definitions from child and parent
are not merged when version differs
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3866:
-----------------------------------
Attachment: plugin-model-container.patch
Proposed patch, using a dedicated PluginModelContainer.
> Plugin definitions from child and parent are not merged when version differs
> ----------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3866) [regression] Plugin definitions from
child and parent are not merged when version differs
Posted by "Shane Isbell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shane Isbell closed MNG-3866.
-----------------------------
Resolution: Fixed
> [regression] Plugin definitions from child and parent are not merged when version differs
> -----------------------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3866) Plugin definitions from child and
parent are not merged when version differs
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155875#action_155875 ]
Benjamin Bentmann commented on MNG-3866:
----------------------------------------
Another example parent POM snippet:
{code:xml}
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.0-beta-7</version>
<configuration>
<goals>deploy</goals>
</configuration>
</plugin>
</plugins>
</build>
{code}
Child POM snippet:
{code:xml}
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.0-beta-8</version>
</plugin>
</plugins>
</build>
{code}
Effective child POM for Maven 2.0.9:
{code:xml}
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.0-beta-8</version>
<configuration>
<goals>deploy</goals>
</configuration>
</plugin>
</plugins>
</build>
{code}
Effective child POM for Maven 3.x trunk:
{code:xml}
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.0-beta-8</version>
</plugin>
</plugins>
</build>
{code}
> Plugin definitions from child and parent are not merged when version differs
> ----------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) [regression] Plugin definitions from
child and parent are not merged when version differs
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann updated MNG-3866:
-----------------------------------
Summary: [regression] Plugin definitions from child and parent are not merged when version differs (was: Plugin definitions from child and parent are not merged when version differs)
> [regression] Plugin definitions from child and parent are not merged when version differs
> -----------------------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) [regression] Plugin definitions from
child and parent are not merged when version differs
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-3866:
-------------------------------
Fix Version/s: (was: 3.0-alpha-3)
3.0-alpha-2
> [regression] Plugin definitions from child and parent are not merged when version differs
> -----------------------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Assignee: Shane Isbell
> Fix For: 3.0-alpha-2
>
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3866) [regression] Plugin definitions from
child and parent are not merged when version differs
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3866:
------------------------------
Fix Version/s: 3.0-alpha-3
Patch Submitted: [Yes]
> [regression] Plugin definitions from child and parent are not merged when version differs
> -----------------------------------------------------------------------------------------
>
> Key: MNG-3866
> URL: http://jira.codehaus.org/browse/MNG-3866
> Project: Maven 2
> Issue Type: Bug
> Components: Inheritance and Interpolation
> Affects Versions: 3.0-alpha-1
> Reporter: Benjamin Bentmann
> Fix For: 3.0-alpha-3
>
> Attachments: plugin-model-container.patch
>
>
> Parent POM snippet
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <!-- Note missing version element -->
> <configuration>
> <stringParam>PASSED</stringParam>
> </configuration>
> </plugin>
> </plugins>
> {code}
> Child POM snippet:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> Effective child POM:
> {code:xml}
> <plugins>
> <plugin>
> <groupId>org.apache.maven.its.plugins</groupId>
> <artifactId>maven-it-plugin-configuration</artifactId>
> <version>2.1-SNAPSHOT</version>
> </plugin>
> </plugins>
> {code}
> i.e. the configuration from the parent POM is completely lost.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira