[jira] Commented: (MYFACES-210) Undesired dependency on ApplicationImpl in FacesConfigurator

["Martin Marinschek (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-210?page=comments#action_12365272 ] 

Martin Marinschek commented on MYFACES-210:
-------------------------------------------

    private void setConverterProperties(Class converterClass, Converter converter)
    {
        org.apache.myfaces.config.impl.digester.elements.Converter converterConfig =
                (org.apache.myfaces.config.impl.digester.elements.Converter)
                    _converterClassNameToConfigurationMap.get(converterClass.getName());

        if(converterConfig != null)
        {

            Iterator it = converterConfig.getProperties();

            while (it.hasNext())
            {
                Property property = (Property) it.next();

                try
                {
                    BeanUtils.setProperty(converter,property.getPropertyName(),property.getDefaultValue());
                }
                catch(Throwable th)
                {
                    log.error("Initializing converter : "+converterClass.getName()+" with property : "+
                            property.getPropertyName()+" and value : "+property.getDefaultValue()+" failed.");
                }
            }
        }
    }

the source-code regarding this has been changed - the converterConfig is now checked. This should be fixed.

regards,

Martin

> Undesired dependency on ApplicationImpl in FacesConfigurator
> ------------------------------------------------------------
>
>          Key: MYFACES-210
>          URL: http://issues.apache.org/jira/browse/MYFACES-210
>      Project: MyFaces
>         Type: Bug
>   Components: Implementation
>     Versions: 1.0.9m9
>  Environment: Custom ApplicationFactory and Application Objects
>     Reporter: Walter Snel
>     Assignee: Martin Marinschek
>     Priority: Minor
>      Fix For: Nightly

>
> Manfred's recent additions related to the configurability of Converters created a dependency on a particular Application implementation in the FacesConfigurator.
> I noticed this because I'm using a custom ApplicationFactory that returns a custom Facade (with augmentations) to the ApplicationImpl class.
> In this case the FacesConfigurator doesn't call the addConverterConfiguration. This, later on, leads to horrible nullpointer exceptions when any of standard converters are used. Perhaps we could consider using relfection instead of the current 'instanceof' mechanism to find out if the addConverterConfiguration() method is supported ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira