You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "ministat (via GitHub)" <gi...@apache.org> on 2023/05/30 06:31:55 UTC
[GitHub] [tinkerpop] ministat opened a new pull request, #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
ministat opened a new pull request, #2079:
URL: https://github.com/apache/tinkerpop/pull/2079
Support SSL connection in WebSocketClient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #2079:
URL: https://github.com/apache/tinkerpop/pull/2079#issuecomment-1570132145
hi @ministat i don't think i see a problem with this change but could you say more about why you want to include SSL here. Since the `WebSocketClient` is just for testing and we test SSL with the actual `Cluster` class, I was just wondering if you had some other reason for wanting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette merged PR #2079:
URL: https://github.com/apache/tinkerpop/pull/2079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] ministat commented on pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
Posted by "ministat (via GitHub)" <gi...@apache.org>.
ministat commented on PR #2079:
URL: https://github.com/apache/tinkerpop/pull/2079#issuecomment-1571219041
I'm working on building a RESTful service which provides gremlin query capability and integrated with the company's frontend. Its implementation depends on gremlin-driver and gremlin-server.
For security requirement, I have enabled SSL. Currently, the WebSocketClient is not a mandatory requirement. But I'm thinking if the frontend supports WebSocket which is on plan, I also need to consider using WebSocketClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2079:
URL: https://github.com/apache/tinkerpop/pull/2079#issuecomment-1567858535
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2079?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2079](https://app.codecov.io/gh/apache/tinkerpop/pull/2079?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (35a99f0) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/55840b998b24c7cf3ca067231562d85248306831?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (55840b9) will **decrease** coverage by `5.19%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2079 +/- ##
=============================================
- Coverage 69.42% 64.24% -5.19%
=============================================
Files 866 25 -841
Lines 41251 3759 -37492
Branches 5442 0 -5442
=============================================
- Hits 28639 2415 -26224
+ Misses 10709 1166 -9543
+ Partials 1903 178 -1725
```
[see 841 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2079/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on PR #2079:
URL: https://github.com/apache/tinkerpop/pull/2079#issuecomment-1577285454
sorry, i saw your reply and forgot to respond last week. ok, if you think you need `WebSocketClient` for your testing then this change is fine i guess.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org