You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/03/28 09:08:52 UTC

[GitHub] [bookkeeper] sijie opened a new pull request #2300: Unable to enable TLS if using v2 protocol

sijie opened a new pull request #2300: Unable to enable TLS if using v2 protocol
URL: https://github.com/apache/bookkeeper/pull/2300
 
 
   Descriptions of the changes in this PR:
   
   *Motivation*
   
   TLS is enabled using `startTLS` but the `startTLS`
   is a v3 protobuf request. So if the client is
   configured to use v2 protocol, the client is not
   able to decode `startTLSResponse`.
   
   *Modifications*
   
   This change is to improve the v2 protocol response handling for
   handling `startTLS` response.
   
   > ---
   > In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
   > checks for pull requests. A pull request can only be merged when it passes precommit checks.
   >
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [bookkeeper] sijie merged pull request #2300: Unable to enable TLS if using v2 protocol

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #2300: Unable to enable TLS if using v2 protocol
URL: https://github.com/apache/bookkeeper/pull/2300
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services