You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/01 20:08:38 UTC

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #19266: Limit the number of ElementWiseSum kernels compiled by RTC

ptrendx opened a new pull request #19266:
URL: https://github.com/apache/incubator-mxnet/pull/19266


   ## Description ##
   This PR limits the number of kernels compiled by RTC for ElementWiseSum - not limiting the inputs to the launcher was resulting in code like this:
   ```
   using InputType0 = float32;
   ...
   using InputType10 = float32;
   ```
   which, even though the types beyond 4 were not used, was treated by a kernel cache as a new kernel, increasing the time needed to start the computation (as more kernels needed to be compiled).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19266: Limit the number of ElementWiseSum kernels compiled by RTC

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19266:
URL: https://github.com/apache/incubator-mxnet/pull/19266#issuecomment-702369790


   Hey @ptrendx , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [sanity, unix-cpu, unix-gpu, miscellaneous, windows-gpu, windows-cpu, edge, clang, centos-cpu, website, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] DickJC123 merged pull request #19266: Limit the number of ElementWiseSum kernels compiled by RTC

Posted by GitBox <gi...@apache.org>.
DickJC123 merged pull request #19266:
URL: https://github.com/apache/incubator-mxnet/pull/19266


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ptrendx commented on pull request #19266: Limit the number of ElementWiseSum kernels compiled by RTC

Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #19266:
URL: https://github.com/apache/incubator-mxnet/pull/19266#issuecomment-703759614


   Makes sense - frankly I did not notice that the 2 branches became so similar to each other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org