You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/02/02 22:40:01 UTC

[GitHub] [samza] rmatharu commented on pull request #1457: SAMZA-2563, SAMZA-2618: Fix double counting of InMemoryKeyValueStore deletion and add per-container metric for memory-utilization

rmatharu commented on pull request #1457:
URL: https://github.com/apache/samza/pull/1457#issuecomment-772061554


   Change looks good, do you think it'd be possible to split them into two PRs so that they go as 2 commits, in case we need to revert one and keep the other.
   
   Also looks like travis is failing, can you ensure your change is rebased on master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org