Re: [PR] [SPARK-46536][SQL] Support GROUP BY calendar_interval_type [spark]

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1438554749


##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java:
##########
@@ -44,7 +44,7 @@
  * @since 3.0.0
  */
 @Unstable
-public final class CalendarInterval implements Serializable {
+public final class CalendarInterval implements Serializable, Comparable<CalendarInterval> {

Review Comment:
   Interesting. Please check the behavior
   https://github.com/apache/spark/pull/27262
   I'm not sure. @yaooqinn



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org