You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "strongduanmu (via GitHub)" <gi...@apache.org> on 2026/04/28 08:12:14 UTC

[PR] Minor refactor encrypt class [shardingsphere]

strongduanmu opened a new pull request, #38658:
URL: https://github.com/apache/shardingsphere/pull/38658

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Minor refactor encrypt class
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor encrypt class [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #38658:
URL: https://github.com/apache/shardingsphere/pull/38658#issuecomment-4333524233

   • Merge Verdict: Mergeable
   
     Reviewed Scope: PR latest head 16675fa; encrypt API/core changes in:
   
     - features/encrypt/api/.../EncryptColumnItemType.java
     - features/encrypt/core/.../EncryptInsertOnUpdateTokenGenerator.java
     - features/encrypt/core/.../EncryptPredicateValueTokenGenerator.java
     - features/encrypt/core/.../EncryptInsertColumnToken.java
   
     Not Reviewed Scope: Maven/CI/tests were not rerun in this round per your request. GitHub Required - Check had succeeded when checked; other CI/E2E workflows were still in_progress.
   
     Need Expert Review: No.
   
     Basis
   
     - EncryptColumnItemType is a 100% rename from encrypt-core to encrypt-api, with the same FQCN. encrypt-core already depends on encrypt-api, so no module dependency break was found.
     - The DatabaseTypeRegistry changes do not alter schema fallback, quote character handling, routing, or SQL parsing semantics.
     - EncryptInsertColumnToken only extracts literal formatting into a private method. rg getParameterMarkerCount found no repository usage, so removing that internal public method has no in-repo call-chain impact.
     - Encrypt rewrite is shared by JDBC and Proxy. I reviewed INSERT VALUES, ON DUPLICATE KEY UPDATE, predicate value rewriting, schema-present/default-schema fallback, and parameter/literal/column expression adjacent paths. No newly introduced regression path
       was found.
     - No SQL parser change, no new dependency, and no documentation semantic update required.
   
     Commands
   
     - git rev-parse HEAD -> exit 0, matched PR head 16675fa
     - git diff --find-renames HEAD^ HEAD --check -> exit 0
     - rg "getParameterMarkerCount" --glob '!target/**' -> exit 1, meaning no in-repo references
     - rg "EncryptColumnItemType" --glob '!target/**' -> exit 0, used to confirm imports and call sites
     - Maven/CI/tests were skipped per your request
   
     Pre-merge next step: wait for the remaining GitHub workflows to finish.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor refactor encrypt class [shardingsphere]

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #38658:
URL: https://github.com/apache/shardingsphere/pull/38658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org