You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Zir0-93 (via GitHub)" <gi...@apache.org> on 2026/10/03 02:31:57 UTC

[PR] Fix class names in the codebase, cgroup, metrics and Kafka docs (storm)

Zir0-93 opened a new pull request, #9156:
URL: https://github.com/apache/storm/pull/9156

   ## What is the purpose of the change
   
   A few pages under `docs/` use class names the code doesn't have anymore:
   
   - `Structure-of-the-codebase.md` links `org.apache.storm.daemon.DrpcServer`, which went away back in 2016 (STORM-2217). The DRPC server is `org.apache.storm.daemon.drpc.DRPCServer` in storm-webapp now, so the entry and link point there.
   - `cgroups_in_storm.md` says `CGroupCPU`, but the class is `CGroupCpu`, and so are the gauge names (`CGroupCpu.user-ms`, `CGroupCpu.sys-ms`).
   - `metrics_v2.md` calls the filter interface `StormMetricFilter`. It's `StormMetricsFilter`, like the code block right under it shows.
   - `storm-kafka-client.md` lists `TridentStateFactory` and `TridentKafkaUpdater` in `org.apache.storm.kafka.trident`. That package has `TridentKafkaStateFactory` and `TridentKafkaStateUpdater` instead. `TridentState` on the same line is really `TridentKafkaState`, so I fixed that one too.
   
   ## How was the change tested
   
   Docs only, didn't build the site. I checked each new name against the source on master.
   
   Found these with Striff, a tool I'm working on that checks docs against the code ([storm's report](https://striff.io/apache/storm?utm_source=github&utm_medium=pull_request&utm_campaign=doc-fix&utm_content=apache-storm) if you're curious).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix class names in the codebase, cgroup, metrics and Kafka docs (storm)

Posted by "reiabreu (via GitHub)" <gi...@apache.org>.
reiabreu merged PR #9156:
URL: https://github.com/apache/storm/pull/9156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix class names in the codebase, cgroup, metrics and Kafka docs (storm)

Posted by "reiabreu (via GitHub)" <gi...@apache.org>.
reiabreu commented on PR #9156:
URL: https://github.com/apache/storm/pull/9156#issuecomment-5967727741

   Thanks for this PR!
   One small request, non-blocking: could you drop the UTM tracking parameters from the Striff link in the description (?utm_source=github&utm_medium=pull_request&utm_campaign=doc-fix…)? A plain link is fine if it's useful context, but the campaign-tagged URL reads as promotional for an ASF PR. Thanks for catching these.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org