You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "rdhabalia (via GitHub)" <gi...@apache.org> on 2023/02/27 20:15:17 UTC
[GitHub] [bookkeeper] rdhabalia opened a new pull request, #3823: Fix: typo for ledger-metadata param: restorefromfile
rdhabalia opened a new pull request, #3823:
URL: https://github.com/apache/bookkeeper/pull/3823
### Motivation
https://github.com/apache/bookkeeper/pull/2019 has introduced a typo in ledgerMetadata bk-shell command which checks invalid input param `restorefromefile` instead of `restorefromfile`. so, this PR fixes that typo which will not cause any compatibility issue for this functionality as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3823: Fix: typo for ledger-metadata param: restorefromfile
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3823:
URL: https://github.com/apache/bookkeeper/pull/3823#issuecomment-1447052173
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3823](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df7b570) into [master](https://codecov.io/gh/apache/bookkeeper/commit/c389b96f12cd8dbcb654acc84234afe3f981f698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c389b96) will **decrease** coverage by `14.91%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3823 +/- ##
=============================================
- Coverage 47.46% 32.56% -14.91%
+ Complexity 4570 3108 -1462
=============================================
Files 473 473
Lines 40963 40963
Branches 5240 5240
=============================================
- Hits 19443 13339 -6104
- Misses 19524 25959 +6435
+ Partials 1996 1665 -331
```
| Flag | Coverage Δ | |
|---|---|---|
| remaining | `29.55% <0.00%> (+<0.01%)` | :arrow_up: |
| replication | `?` | |
| tls | `21.07% <0.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/bookkeeper/bookie/BookieShell.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0Jvb2tpZVNoZWxsLmphdmE=) | `0.00% <0.00%> (-0.68%)` | :arrow_down: |
| [...ols/cli/commands/client/LedgerMetaDataCommand.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdG9vbHMvY2xpL2NvbW1hbmRzL2NsaWVudC9MZWRnZXJNZXRhRGF0YUNvbW1hbmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/bookkeeper/server/conf/BookieConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2NvbmYvQm9va2llQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../bookkeeper/metastore/MetastoreScannableTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVNjYW5uYWJsZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...bookkeeper/server/http/service/MetricsService.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9NZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ookkeeper/server/service/StatsProviderService.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL3NlcnZpY2UvU3RhdHNQcm92aWRlclNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...eper/server/http/service/ConfigurationService.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9Db25maWd1cmF0aW9uU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...per/bookie/storage/ldb/KeyValueStorageFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL3N0b3JhZ2UvbGRiL0tleVZhbHVlU3RvcmFnZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...per/meta/LongHierarchicalLedgerManagerFactory.java](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9Mb25nSGllcmFyY2hpY2FsTGVkZ2VyTWFuYWdlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [211 more](https://codecov.io/gh/apache/bookkeeper/pull/3823?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3823: Fix: typo for ledger-metadata param: restorefromfile
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3823:
URL: https://github.com/apache/bookkeeper/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org