Possible error in rpm-creation automation

[Matt England <me...@mengland.net>]

Possible error in rpm-creation automation in this Makefile (and possibly 
others):

http://svn.collab.net/repos/svn/trunk/packages/rpm/rhel-4/Makefile

If the user has an existing $(HOME)/.rpmmacros file that doesn't have the 
proper content (eg, if they were building other rpms besides Subversion's), 
then it appears that the above make process would break.

I'm writing up a fix for this in my project's rpm Makefile, don't have it 
done yet, but I wanted to mention this here in case I forget.  I can 
present my code later; if anyone's interested, just send me a direct note 
to my email addr to remind me.

-Matt


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Possible error in rpm-creation automation

[Daniel Rall <dl...@collab.net>]

On Mon, 17 Apr 2006, Matt England wrote:

> Possible error in rpm-creation automation in this Makefile (and possibly 
> others):
> 
> http://svn.collab.net/repos/svn/trunk/packages/rpm/rhel-4/Makefile
> 
> If the user has an existing $(HOME)/.rpmmacros file that doesn't have the 
> proper content (eg, if they were building other rpms besides Subversion's), 
> then it appears that the above make process would break.
> 
> I'm writing up a fix for this in my project's rpm Makefile, don't have it 
> done yet, but I wanted to mention this here in case I forget.  I can 
> present my code later; if anyone's interested, just send me a direct note 
> to my email addr to remind me.


Matt, please do submit a patch when you have the change ready.

  http://subversion.tigris.org/hacking.html#patches

Thanks, Dan