You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/03 22:53:06 UTC
[GitHub] [incubator-superset] JasonD28 opened a new issue #10788: values in SQLObservations for alerting are rounded
JasonD28 opened a new issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788
When creating and triggering a SQL-based alert the values stored in the alert observations are rounded to a high degree. Starting at numbers in the:
- 100,000s → rounded to the nearest 1s place
- 1,000,000 → rounded to the nearest 10s place
- 10,000,000 → rounded to the nearest 100s place
- ... etc
### Expected results
"List Observations" tab for an alert to hold values that accurately reflect the value returned from the SQL query in the alert's SQLObserver object.
### Actual results
Values in the "List Observations" tab differ from the values returned by the associated SQL query due to rounding.
#### Screenshots
Seen in the List Observations tab of an alert:
The correct value returned from the alert's SQL query was 711960960
#### How to reproduce the bug
1. set up config.py to enable alerting
```
ENABLE_ALERTS = True
FEATURE_FLAGS = {"THUMBNAILS": True}
THUMBNAIL_SELENIUM_USER = "Admin"
celery_alerting = {'alerts.schedule_check': {
'task': 'alerts.schedule_check',
'schedule': crontab(minute='*/1'),
}}
CeleryConfig.CELERYBEAT_SCHEDULE.update(celery_alerting)
CELERY_CONFIG = CeleryConfig
```
2. Go to Settings -> Alerts
3. Create an alert
4. Edit the alert and create a SQLObserver
- a simple SQL query like `SELECT 1234567` or any bigger number will work
5. Go back to the "Details" tab of the alert and click "Send Test Alert"
6. Save Alert
7. Click magnifying glass next to alert to view details
8. Go to "List Observations"
### Environment
(please complete the following information):
- superset version: 0.37
- python version: 3.7.7
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-716557634
Hi @JasonD28,
I wasn't able to replicate the problem, used a very simple trigger alert query `select 123456789123` and observed the following:
<img width="1171" alt="Screenshot 2020-10-26 at 13 45 57" src="https://user-images.githubusercontent.com/4025227/97180310-cbb0f200-1791-11eb-9eab-221a014b417f.png">
Looks good! This feature was subject to a recent refactor, can you please fetch the latest master the re-test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-687437537
:label alerts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-686803620
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.91. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-720524135
Going to close this issue, feel free to reopen if your still experiencing this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
dpgaspar closed issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JasonD28 commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
JasonD28 commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-686803656
@bkyryliuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett edited a comment on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
willbarrett edited a comment on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-687437537
:label: alerts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-686881361
🏷 SQLObserver
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pawnZzz commented on issue #10788: values in SQLObservations for alerting are rounded
Posted by GitBox <gi...@apache.org>.
pawnZzz commented on issue #10788:
URL: https://github.com/apache/incubator-superset/issues/10788#issuecomment-711937502
@JasonD28 Can You show me your configuration？I can't find the content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org