You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/21 05:08:05 UTC

[GitHub] [incubator-druid] jihoonson opened a new pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests

jihoonson opened a new pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests
URL: https://github.com/apache/incubator-druid/pull/8350
 
 
   ### Description
   
   - In native parallel indexing, the shuffle didn't work if TLS is enabled because it didn't use the escalated http client. This PR fixes `PartialSegmentMergeTask` to use the escalated client. 
   - `FullResponseHolder` and `BytesFullResponseHolder` were refactored to remove the existing strange inheritance relation.
   - Improved `MultiPhaseParallelIndexingTest` to verify that the created segments are well partitioned.
   - Added an integration test for native parallel indexing with shuffle.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [x] added integration tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org