[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string

[GitBox <gi...@apache.org>]

gyfora commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1091392102

   > Hmm. I prefer to store the lastReconciledSpec without spaces, line break, etc. since we are showing a json in a yaml format.
   > 
   > ```
   > Last Reconciled Spec: {"image":"flink:1.14","imagePullPolicy":null,"serviceAccount":"flink","flinkVersion":"v1_14","ingress":null,"flinkConfiguration":{"taskmanager.numberOfTaskSlots":"2"},"podTemplate":null,"jobManager":{"resource":{"cpu":1,"memory":"2048m"},"replicas":1,"podTemplate":null},"taskManager":{"resource":{"cpu":1,"memory":"2048m"},"podTemplate":null},"job":{"jarURI":"local:///opt/flink/examples/streaming/StateMachineExample.jar","parallelism":2,"entryClass":null,"args":[],"state":"running","savepointTriggerNonce":null,"initialSavepointPath":null,"upgradeMode":"stateless"},"restartNonce":null,"logConfiguration":null}
   > ```
   
   @wangyang0918 taht would be trivial to change, I thought this looks better for the user to read but otherwise I dont have a strong preference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org