You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/10/05 21:10:04 UTC

[GitHub] [activemq-artemis] clebertsuconic opened a new pull request, #4242: ARTEMIS-4029 Avoid OME When too many pages are cleared all at once

clebertsuconic opened a new pull request, #4242:
URL: https://github.com/apache/activemq-artemis/pull/4242

   The issue is that depage should not put pages on the used pages as they were not actually intended to read. instead I should create a newPageObject and not use the RefCounts caching.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] clebertsuconic merged pull request #4242: ARTEMIS-4029 Avoid OME When too many pages are cleared all at once

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged PR #4242:
URL: https://github.com/apache/activemq-artemis/pull/4242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] AntonRoskvist commented on pull request #4242: ARTEMIS-4029 Avoid OME When too many pages are cleared all at once

Posted by GitBox <gi...@apache.org>.
AntonRoskvist commented on PR #4242:
URL: https://github.com/apache/activemq-artemis/pull/4242#issuecomment-1269437407

   @clebertsuconic I made a test run and it's looking great. Broker starts up just as expected. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4242: ARTEMIS-4029 Avoid OME When too many pages are cleared all at once

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4242:
URL: https://github.com/apache/activemq-artemis/pull/4242#issuecomment-1269185323

   @AntonRoskvist if you could test this with the data you saved...
   
   
   I created a test based on the description of your problem... and I believe I addressed the issue, but if you could verify this?
   
   
   
   One note aside: The Full test suite passed with this PR. (not just the fast PR tests.. but the multi-hour test suite on my CI.. so these changes are tested and ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org