You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/01/02 12:00:09 UTC
[PR] Remove code references to hadoop-hdfs [polaris]
adutra opened a new pull request, #599:
URL: https://github.com/apache/polaris/pull/599
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Honor issued token type reported by token broker [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #599:
URL: https://github.com/apache/polaris/pull/599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Honor issued token type reported by token broker [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #599:
URL: https://github.com/apache/polaris/pull/599#discussion_r1901150378
##########
service/common/src/main/java/org/apache/polaris/service/auth/DefaultOAuth2ApiService.java:
##########
@@ -114,8 +116,8 @@ public Response getToken(
return Response.ok(
OAuthTokenResponse.builder()
.withToken(tokenResponse.getAccessToken())
- .withTokenType(OAuth2Constants.BEARER)
- .withIssuedTokenType(OAuth2Properties.ACCESS_TOKEN_TYPE)
+ .withTokenType(BEARER)
+ .withIssuedTokenType(tokenResponse.getTokenType())
Review Comment:
sweet :+1: thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code references to hadoop-hdfs [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #599:
URL: https://github.com/apache/polaris/pull/599#discussion_r1901143227
##########
service/common/src/main/java/org/apache/polaris/service/auth/DefaultOAuth2ApiService.java:
##########
@@ -114,8 +116,8 @@ public Response getToken(
return Response.ok(
OAuthTokenResponse.builder()
.withToken(tokenResponse.getAccessToken())
- .withTokenType(OAuth2Constants.BEARER)
- .withIssuedTokenType(OAuth2Properties.ACCESS_TOKEN_TYPE)
+ .withTokenType(BEARER)
+ .withIssuedTokenType(tokenResponse.getTokenType())
Review Comment:
nit: this looks like a functional change, not just "remove references to hadoop", even though it does make sense :) maybe rephrase the PR subject line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove code references to hadoop-hdfs [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #599:
URL: https://github.com/apache/polaris/pull/599#discussion_r1901148588
##########
service/common/src/main/java/org/apache/polaris/service/auth/DefaultOAuth2ApiService.java:
##########
@@ -114,8 +116,8 @@ public Response getToken(
return Response.ok(
OAuthTokenResponse.builder()
.withToken(tokenResponse.getAccessToken())
- .withTokenType(OAuth2Constants.BEARER)
- .withIssuedTokenType(OAuth2Properties.ACCESS_TOKEN_TYPE)
+ .withTokenType(BEARER)
+ .withIssuedTokenType(tokenResponse.getTokenType())
Review Comment:
Done, let me know if that's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org