You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/23 17:03:52 UTC
[GitHub] villebro edited a comment on issue #5467: Fix broken dedup and
remove redundant db_spec logic
villebro edited a comment on issue #5467: Fix broken dedup and remove redundant db_spec logic
URL: https://github.com/apache/incubator-superset/pull/5467#issuecomment-407129024
@mistercrunch The lowercasing hack was introduced to deal with SQLA engines that returned different cases for column names in the cursor.description (db api 1) which was used by e.g. SQL Lab and ResultProxy.keys() (db api 2), which was used for retrieving data. #5178 replaced all v2 api calls with v1 calls, ensuring that the column names are always of the same case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org