You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2017/05/11 20:14:03 UTC
Review Request 59201: Ported the IPNetwork::fromLinkDevice to the
Windows Platform.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59201/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-5938
https://issues.apache.org/jira/browse/MESOS-5938
Repository: mesos
Description
-------
Note that, on Windows, IPNetwork::fromLinkDevice takes a MAC address
rather than a network name. See associated chagnes to net::links for
an explanation of why this is the case.
Diffs
-----
3rdparty/stout/include/stout/ip.hpp ad2bd922158eecd12b51b272d2a003b8ec8d3550
3rdparty/stout/include/stout/posix/ip.hpp PRE-CREATION
3rdparty/stout/include/stout/windows/ip.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/59201/diff/1/
Testing
-------
See final commit for tests performed.
Thanks,
Jeff Coffler
Re: Review Request 59201: Ported the IPNetwork::fromLinkDevice to the
Windows Platform.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59201/#review176667
-----------------------------------------------------------
I can fix this up before committing.
3rdparty/stout/include/stout/posix/ip.hpp
Lines 30-32 (patched)
<https://reviews.apache.org/r/59201/#comment250083>
Won't be needing this anymore.
3rdparty/stout/include/stout/posix/ip.hpp
Lines 95 (patched)
<https://reviews.apache.org/r/59201/#comment250519>
copy-paste mistake?
3rdparty/stout/include/stout/windows/ip.hpp
Lines 25-28 (patched)
<https://reviews.apache.org/r/59201/#comment250520>
Only 64bit is supported, so this is not needed.
3rdparty/stout/include/stout/windows/ip.hpp
Lines 43-45 (patched)
<https://reviews.apache.org/r/59201/#comment250521>
I'll add a TODO to add IPv6 support. The `GetAdaptersAddresses` method should do the trick.
3rdparty/stout/include/stout/windows/ip.hpp
Lines 64-70 (patched)
<https://reviews.apache.org/r/59201/#comment250522>
As we discussed offline and in the previous review, we can use the `AdapterName` here.
- Joseph Wu
On May 11, 2017, 1:14 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59201/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 1:14 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-5938
> https://issues.apache.org/jira/browse/MESOS-5938
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note that, on Windows, IPNetwork::fromLinkDevice takes a MAC address
> rather than a network name. See associated chagnes to net::links for
> an explanation of why this is the case.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/ip.hpp ad2bd922158eecd12b51b272d2a003b8ec8d3550
> 3rdparty/stout/include/stout/posix/ip.hpp PRE-CREATION
> 3rdparty/stout/include/stout/windows/ip.hpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59201/diff/1/
>
>
> Testing
> -------
>
> See final commit for tests performed.
>
>
> Thanks,
>
> Jeff Coffler
>
>