[jira] [Commented] (SAMZA-737) config docs: property names stores.store-name.changelog.replication.factor and stores.store-name.changelog.topic-level-property are incorrect

["Yi Pan (Data Infrastructure) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632143#comment-14632143 ] 

Yi Pan (Data Infrastructure) commented on SAMZA-737:
----------------------------------------------------

Hi, [~cwlaird3], what's the reason that you think the property names are wrong? Are you referring to the fact that the replication factor and topic-level-property only applies to Kafka hence it should be renamed? Or the current names simply does not work in Samza config?

If you are referring to the first one, it would worth a bigger scope of discussion: for Samza internal topics, we are using Kafka and w/o rewinding, partitioning, and log-compaction features in Kafka, it won't work. The bigger question is whether we should just make the definite call that changelogs/checkpoints/coordinator streams should just strictly be Kafka system, since other messaging systems do not provide these functions.

> config docs: property names stores.store-name.changelog.replication.factor and stores.store-name.changelog.topic-level-property are incorrect
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-737
>                 URL: https://issues.apache.org/jira/browse/SAMZA-737
>             Project: Samza
>          Issue Type: Bug
>          Components: docs
>    Affects Versions: 0.9.0
>            Reporter: Carl Laird
>            Priority: Minor
>
> In the following configuration doc:
> http://samza.apache.org/learn/documentation/0.9/jobs/configuration-table.html
> The properties stores.store-name.changelog.replication.factor and stores.store-name.changelog.topic-level-property
> should be stores.store-name.changelog.kafka.replication.factor and stores.store-name.changelog.kafka.topic-level-property



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)