[GitHub] [arrow] ildipo commented on a diff in pull request #34575: GH-15280: [C++] Second block of refactoring to move acero out of libarrow

["ildipo (via GitHub)" <gi...@apache.org>]

ildipo commented on code in PR #34575:
URL: https://github.com/apache/arrow/pull/34575#discussion_r1137696508


##########
cpp/src/arrow/compute/exec/plan_test.cc:
##########
@@ -1016,9 +1019,14 @@ TEST(ExecPlanExecution, ProjectMaintainsOrder) {
   constexpr int kRandomSeed = 42;
   constexpr int64_t kRowsPerBatch = 1;
   constexpr int kNumBatches = 16;
-  auto source_node = gen::Gen({{"x", gen::Step()}})
-                         ->FailOnError()
-                         ->SourceNode(kRowsPerBatch, kNumBatches);
+
+  auto generator = gen::Gen({{"x", gen::Step()}})->FailOnError();

Review Comment:
   This was using generator.h with compute/exec/options.h. I removed that include (and the associated exec options from generator, that is `SourceNode()`) and expanded it in this test, which was the only place where it was used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org