You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/05 21:44:15 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
ustcweizhou opened a new pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
This is regression issue of #3898
The password server in isolated network with RVRs run with wrong parameter
```
root@r-1083-VM:~# ps -ef|grep pass
root 1070 1 0 20:58 ? 00:00:01 python /opt/cloud/bin/passwd_server_ip.py ,192.168.10.84
```
it is because the gateway is "" for eth0 in /etc/cloudstack/ips.json.
This does not impact vpc with redundant VRs.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
restart network with cleanup, the new VR seems ok
```
root@r-1085-VM:~# ps -ef|grep pass
root 5468 1 0 21:37 ? 00:00:00 python /opt/cloud/bin/passwd_server_ip.py 192.168.0.1,192.168.0.28
```
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
This is regression issue of #3898
The password server in isolated network with RVRs run with wrong parameter
```
root@r-1083-VM:~# ps -ef|grep pass
root 1070 1 0 20:58 ? 00:00:01 python /opt/cloud/bin/passwd_server_ip.py ,192.168.10.84
```
it is because the gateway is "" for eth0 in /etc/cloudstack/ips.json.
This does not impact vpc with redundant VRs.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
restart network with cleanup, the new VR seems ok
```
root@r-1085-VM:~# ps -ef|grep pass
root 5468 1 0 21:37 ? 00:00:00 python /opt/cloud/bin/passwd_server_ip.py 192.168.0.1,192.168.0.28
```
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596397527
> @DaanHoogland the fix for private gateway issue is merged into master, not 4.13
should those fixes be backported to 4.13?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595647757
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596062837
@
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3943: vr: fix password
server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595621940
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596090291
@DaanHoogland the private gateway issue is merged into master, not 4.13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595658318
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595623300
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595859474
<b>Trillian test result (tid-1204)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28810 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1204-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 188.87 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 179.20 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 237.15 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Error` | 264.77 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3943: vr: fix password
server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595658251
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3943: vr: fix password
server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595463061
@rhtyd @DaanHoogland @andrijapanicsb sorry found a regression issue. please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596090291
@DaanHoogland the fix for private gateway issue is merged into master, not 4.13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596062972
@weizhouapache the private gateway errors have either not been fixed or have returned. Any resolution/opinion? cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595642180
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596062837
@
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596217471
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3943: vr: fix password
server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-595641903
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596264816
<b>Trillian test result (tid-1214)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26817 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3943-t1214-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 174.65 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 175.00 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 226.93 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3943: vr: fix password
server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943#issuecomment-596217413
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3943: vr: fix
password server run with empty gateway in isolated network with RVRs
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3943: vr: fix password server run with empty gateway in isolated network with RVRs
URL: https://github.com/apache/cloudstack/pull/3943
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
This is regression issue of #3898
The password server in isolated network with RVRs run with wrong parameter
```
root@r-1083-VM:~# ps -ef|grep pass
root 1070 1 0 20:58 ? 00:00:01 python /opt/cloud/bin/passwd_server_ip.py ,192.168.10.84
```
it is because the gateway is "" for eth0 in /etc/cloudstack/ips.json.
This does not impact vpc with redundant VRs.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
restart network with cleanup, the new VR seems ok
```
root@r-1085-VM:~# ps -ef|grep pass
root 5468 1 0 21:37 ? 00:00:00 python /opt/cloud/bin/passwd_server_ip.py 192.168.0.1,192.168.0.28
```
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services