You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jonshea (via GitHub)" <gi...@apache.org> on 2023/05/10 18:42:31 UTC
[GitHub] [airflow] jonshea opened a new pull request, #31189: Remove the upper version bound on pymongo
jonshea opened a new pull request, #31189:
URL: https://github.com/apache/airflow/pull/31189
There was an upper version bound on pymongo of `<4.0.0` because versions 4.0.0+ removed the `ssl_cert_reqs` parameter from client connection options. However, comparing the pymongo 3.7.0 docs (https://pymongo.readthedocs.io/en/3.7.0/examples/tls.html#certificate-verification-policy) to the 4.3.3 docs
(https://pymongo.readthedocs.io/en/4.3.3/examples/tls.html#certificate-verification-policy) it seems that `ssl_cert_reqs` has been effectively renamed to `tlsAllowInvalidCertificates`.
This PR removes upper version bound on pymongo, and adds a test to set `tlsAllowInvalidCertificates` for pymongo 4.0.0 and later, while continuing to use `ssl_cert_reqs` for earlier versions of pymongo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #31189: Remove the upper version bound on pymongo
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #31189:
URL: https://github.com/apache/airflow/pull/31189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31189: Remove the upper version bound on pymongo
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31189:
URL: https://github.com/apache/airflow/pull/31189#issuecomment-1543752760
> I am not certain about what to do for testing. It isn’t clear to me that any existing tests actually connect to a live mongodb instance?
Actually we have integration tests with mongo and they passed:
https://github.com/apache/airflow/actions/runs/4945112005/jobs/8841910985#step:11:596
Not sure though if they are comprehensive enough, so maybe good if you take a look as well?
It's rather easy to run them locally with breeze:
https://github.com/apache/airflow/blob/main/TESTING.rst#airflow-integration-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31189: Remove the upper version bound on pymongo
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31189:
URL: https://github.com/apache/airflow/pull/31189#issuecomment-1543746914
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31189: Remove the upper version bound on pymongo
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31189:
URL: https://github.com/apache/airflow/pull/31189#issuecomment-1543770256
Though in your PR mongo has not been upgraded actually (because it is held back) and the constraints had not updated it:
https://github.com/apache/airflow/actions/runs/4940266515/jobs/8837512485?pr=31189#step:5:17770
But this is actually because of `apache-beam` holding it back:
`apache-beam 2.46.0 requires pymongo<4.0.0,>=3.8.0, but you have pymongo 4.3.3 which is incompatible.`
And we will find out today/tomorrow if all is fine, because `apache-beam 2.47 had **just** been released and we are about to get it upgraded as part of the job in https://github.com/apache/airflow/pull/30067
This `apache-beam` release is something we've been waiting for some time as it held back a number of our dependencies :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jonshea commented on pull request #31189: Remove the upper version bound on pymongo
Posted by "jonshea (via GitHub)" <gi...@apache.org>.
jonshea commented on PR #31189:
URL: https://github.com/apache/airflow/pull/31189#issuecomment-1542649956
I am not certain about what to do for testing. It isn’t clear to me that any existing tests actually connect to a live mongodb instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org