You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "westse (via GitHub)" <gi...@apache.org> on 2024/04/11 18:25:10 UTC
[PR] Spec: required request bodies [iceberg]
westse opened a new pull request, #10125:
URL: https://github.com/apache/iceberg/pull/10125
Closes #10004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: required request bodies [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10125:
URL: https://github.com/apache/iceberg/pull/10125#discussion_r1562319061
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -248,6 +248,7 @@ paths:
The server might also add properties, such as `last_modified_time` etc.
operationId: createNamespace
requestBody:
+ required: true
Review Comment:
can you also please add the same for `getToken`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: required request bodies [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #10125:
URL: https://github.com/apache/iceberg/pull/10125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: required request bodies [iceberg]
Posted by "westse (via GitHub)" <gi...@apache.org>.
westse commented on code in PR #10125:
URL: https://github.com/apache/iceberg/pull/10125#discussion_r1562752513
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -248,6 +248,7 @@ paths:
The server might also add properties, such as `last_modified_time` etc.
operationId: createNamespace
requestBody:
+ required: true
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec: required request bodies [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #10125:
URL: https://github.com/apache/iceberg/pull/10125#issuecomment-2052182543
I'll go ahead and merge, thanks @westse for fixing this and @nastra for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org