You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/03 08:49:37 UTC

[GitHub] [airflow] bhirsz commented on a change in pull request #22692: Add support for Delta Sharing protocol

bhirsz commented on a change in pull request #22692:
URL: https://github.com/apache/airflow/pull/22692#discussion_r841188330



##########
File path: airflow/providers/delta/sharing/example_dags/example_delta_sharing.py
##########
@@ -0,0 +1,77 @@
+#

Review comment:
       General note - I see you've used new system test design (good work!) but I also see example dag here. One of the purposes of new design of system tests was to have system tests that are used as examples - that's why it's better to keep only the one in tests/system and link documentation (like ``howto_delta_sharing_operator`` tag) to system tests. That way you're ensuring that your examples are actually executed and working.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org