[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2982: [Bug] [seatunnel-api-flink] Use the constructor instead of setting the pipeline.jars

[GitBox <gi...@apache.org>]

liugddx commented on code in PR #2982:
URL: https://github.com/apache/incubator-seatunnel/pull/2982#discussion_r1003935259


##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkExecution.java:
##########
@@ -90,6 +111,33 @@ private void registerPlugin() {
 
         pluginsJarDependencies.forEach(url -> FlinkCommon.ADD_URL_TO_CLASSLOADER.accept(Thread.currentThread().getContextClassLoader(), url));
 
-        flinkEnvironment.registerPlugin(pluginsJarDependencies);
+        jarPaths.addAll(pluginsJarDependencies);
+    }
+
+    private Config registerPlugin(Config config, List<URL> jars) {
+        config = this.parseConfig(config, ConfigUtil.joinPath("env", "pipeline", "jars"), jars);
+        return this.parseConfig(config, ConfigUtil.joinPath("env", "pipeline", "classpaths"), jars);

Review Comment:
   > Change the doc to tell user the new way add jar. Also this function should support spark later.
   
   This change does not require a change in usage,it's just the way the jar is injected that has changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org