You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/30 08:18:52 UTC

[GitHub] [openwhisk] ningyougang commented on a change in pull request #4870: Calculate whether exist enough space more carefully

ningyougang commented on a change in pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870#discussion_r400006792
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -119,7 +127,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
         }
         val createdContainer =
           // Is there enough space on the invoker for this action to be executed.
-          if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
+          if (hasPoolSpaceFor(busyPool ++ prewarmedPoolForOtherKind, r.action.limits.memory.megabytes.MB)) {
 
 Review comment:
   Sorry, i didn't get it,
   anyway i send a email to dev-list

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services