You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2003/08/31 17:50:19 UTC

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup SetDocBaseRule.java

remm        2003/08/31 08:50:18

  Modified:    catalina/src/share/org/apache/catalina/startup
                        SetDocBaseRule.java
  Log:
  - Don't unpack if there's an overriding unpackWAR attribute on the context
    itself. I plan to use this to run the tomcat-docs webapp from the WAR (it
    simply uses too much HD space, and takes a while to unpack when
    installing Tomcat, so I'll experiment with bundling it as a WAR).
  
  Revision  Changes    Path
  1.5       +6 -3      jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/SetDocBaseRule.java
  
  Index: SetDocBaseRule.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup/SetDocBaseRule.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- SetDocBaseRule.java	25 Jul 2003 16:43:53 -0000	1.4
  +++ SetDocBaseRule.java	31 Aug 2003 15:50:18 -0000	1.5
  @@ -133,6 +133,9 @@
           if (!((StandardHost) host).isUnpackWARs()) {
               return;
           }
  +        if ("false".equals(attributes.getValue("unpackWAR"))) {
  +            return;
  +        }
   
           File canonicalAppBase = 
               new File(System.getProperty("catalina.base"), appBase)

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/startup SetDocBaseRule.java

Posted by Remy Maucherat <re...@apache.org>.
remm@apache.org wrote:
> remm        2003/08/31 08:50:18
> 
>   Modified:    catalina/src/share/org/apache/catalina/startup
>                         SetDocBaseRule.java
>   Log:
>   - Don't unpack if there's an overriding unpackWAR attribute on the context
>     itself. I plan to use this to run the tomcat-docs webapp from the WAR (it
>     simply uses too much HD space, and takes a while to unpack when
>     installing Tomcat, so I'll experiment with bundling it as a WAR).

I won't be doing that, BTW. It turns out it works great once TC is 
installed and it's a fancy setup (I put a META-INF/context.xml inside 
the .war telling TC not to unpack the WAR), but unfortunately, it makes 
the d/ls significantly bigger (a much as 3MB for the .exe distribution 
for Windows), so it's not a good tradeoff.

I'll leave in the unpackWAR flag. It looks like a reasonably useful 
feature in some situations.

Remy