You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by chunhui-shi <gi...@git.apache.org> on 2017/12/21 00:39:00 UTC

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158103733
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java ---
    @@ -72,7 +72,16 @@ public AbstractSchema getSubSchema(String name) {
         @Override
         public Table getTable(String name) {
           HBaseScanSpec scanSpec = new HBaseScanSpec(name);
    -      return new DrillHBaseTable(schemaName, plugin, scanSpec);
    +      try {
    +        return new DrillHBaseTable(schemaName, plugin, scanSpec);
    +      } catch (Exception e) {
    +        // Calcite firstly is looking for a table in the default schema, if a table was not found,
    +        // it is looking in root schema.
    +        // If a table does not exist, a query will fail at validation stage,
    +        // so the error should not be thrown there.
    --- End diff --
    
    do you mean 'should not be thrown HERE'? The same for other places.


---