[GitHub] [pulsar] k2la commented on issue #8030: enableReplicatedSubscriptions is not used.

[GitBox <gi...@apache.org>]

k2la commented on issue #8030:
URL: https://github.com/apache/pulsar/issues/8030#issuecomment-693996165


   Is the behavior decided when Replicated Subscriptions is OFF ?
   I think the behavior is as the following in the case:
   - Brokers send `NotAllowedException` to consumers that subscribe with replicated subccription.
   - Replicators don't send marker messages and deal with them.
   
   I will try to implement the above behavior by the following ways.
   Please let me know if there are any problems.
   
   #### Brokers send `NotAllowedException` to consumers that subscribe with replicated subccription.
   Like Key_Shared, send `NotAllowedException` in `PersistentTopics#subscribe`:
   https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L533-L539
   
   #### Replicators don't send marker messages and deal with them.
   Broker do not create `ReplicatedSubscriptionsController` instance that sends marker messages.
   Fix to enter the following if statement:
   https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2158-L2162


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org