You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by tjakway <gi...@git.apache.org> on 2018/06/17 23:34:49 UTC
[GitHub] lucene-solr pull request #405: don't die when java prints tool options
GitHub user tjakway opened a pull request:
https://github.com/apache/lucene-solr/pull/405
don't die when java prints tool options
If you have JAVA_TOOL_OPTIONS set (e.g. in my .profile, `export JAVA_TOOL_OPTIONS="-Dfile.encoding=\"UTF-8\" -Dawt.useSystemAAFontSettings=on"`) you get a confusing message about having the wrong version of java installed because the launch script only looks at the first line of the output of `java -version`. Simple 1-liner fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tjakway/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/405.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #405
----
commit 2b4f25f8e6a413cd8911640579f8c19f8c4caf59
Author: Thomas Jakway <tj...@...>
Date: 2018-06-17T23:31:19Z
don't die when java prints tool options
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #405: don't die when java prints tool options
Posted by sarowe <gi...@git.apache.org>.
Github user sarowe commented on the issue:
https://github.com/apache/lucene-solr/pull/405
Can you make a JIRA issue to track this please? https://wiki.apache.org/solr/HowToContribute#JIRA_tips_.28our_issue.2Fbug_tracker.29
Also, it might be better to extract the line containing version info, rather than ignoring specific lines that don't contain it, since there may be other bad output lines in the future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org