You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/14 23:30:38 UTC
[GitHub] [airflow] kaxil opened a new pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
kaxil opened a new pull request #13684:
URL: https://github.com/apache/airflow/pull/13684
closes https://github.com/apache/airflow/issues/13676
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760556753
https://github.com/apache/airflow/blob/2fef2ab1bf0f8c727a503940c9c65fd5be208386/airflow/api_connexion/openapi/v1.yaml#L1876
here this behavior is described in the spec. Storing large objects in XCOM is not recommended, but unfortunately some people store larger objects in Xcom and the API should still behave stably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760551618
> this field could potentially be very large so it does not show up in the list. You must download a single item to download its contents.
We should replicate what we do in the UI -- we ask everyone to not store large values in XCom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760551618
> this field could potentially be very large so it does not show up in the list. You must download a single item to download its contents.
We should replicate what we do in the UI -- we ask everyone to not store large values in XCom
I have pushed 5c889d4fe that does what you suggested and add an explanation for it. But not entirely convinced yet to leave value out from list endpoint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760557189
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760549190
this field could potentially be very large so it does not show up in the list. You must download a single item to download its contents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13684:
URL: https://github.com/apache/airflow/pull/13684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760550566
https://github.com/apache/airflow/blob/2fef2ab1bf0f8c727a503940c9c65fd5be208386/airflow/api_connexion/endpoints/xcom_endpoint.py#L97
```diff
- return xcom_collection_item_schema.dump(query_object)
+ return xcom_schema.dump(query_object)
```
That should fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13684: Bugfix: Return XCom Value in the XCom Endpoint API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13684:
URL: https://github.com/apache/airflow/pull/13684#issuecomment-760550566
https://github.com/apache/airflow/blob/master/airflow/api_connexion/endpoints/xcom_endpoint.py#L97
```diff
- return xcom_collection_item_schema.dump(query_object)
+ return xcom_schema.dump(query_object)
```
That should fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org