You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/11 02:34:50 UTC

[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #98: [Bugfix] allow pending data to send before exit

tom-pytel commented on a change in pull request #98:
URL: https://github.com/apache/skywalking-python/pull/98#discussion_r540645702



##########
File path: skywalking/agent/__init__.py
##########
@@ -38,7 +39,8 @@ def __heartbeat():
 def __report():
     while not __finished.is_set():
         if connected():
-            __protocol.report(__queue)  # is blocking actually
+            while __protocol.report(__queue):  # blocking but has timeout
+                pass

Review comment:
       You are right on both counts, the `return True` from `Protocol.report()` also becomes unnecessary, stuck around from first commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org