You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/13 06:37:56 UTC
[GitHub] [airflow] potiuk opened a new pull request #16959: Fixes passing variables via docker --env-file command
potiuk opened a new pull request #16959:
URL: https://github.com/apache/airflow/pull/16959
The #16950 aimed to fix an incompatibility introduced by
beta version of docker-compose v2 (which is automatically pushed
to MacOS users now).
The issue is documented in
https://github.com/docker/compose-cli/issues/1917
Unfortunately it has an undesired side-effect that the same file
cannot be used to specify list of variables for docker command
(the variables come empty).
Until the problem is solved, we need to keep two copies of those
variable files. Not ideal, but hopefully the issue will be solved
soon and we can go back to original env file in docker-compose v2.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16959: Fixes passing variables via docker --env-file command
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16959:
URL: https://github.com/apache/airflow/pull/16959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16959: Fixes passing variables via docker --env-file command
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16959:
URL: https://github.com/apache/airflow/pull/16959#discussion_r668682819
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -26,7 +26,7 @@ services:
- KUBECONFIG=/files/.kube/config
- HOST_HOME=${HOME}
env_file:
- - _docker.env
+ - _docke_compose.env
Review comment:
Silly me. Thanks @feluelle !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16959: Fixes passing variables via docker --env-file command
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16959:
URL: https://github.com/apache/airflow/pull/16959#issuecomment-878824939
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #16959: Fixes passing variables via docker --env-file command
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #16959:
URL: https://github.com/apache/airflow/pull/16959#discussion_r668636852
##########
File path: scripts/ci/docker-compose/base.yml
##########
@@ -26,7 +26,7 @@ services:
- KUBECONFIG=/files/.kube/config
- HOST_HOME=${HOME}
env_file:
- - _docker.env
+ - _docke_compose.env
Review comment:
typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org