[GitHub] [brooklyn-server] duncangrant commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests

[GitBox <gi...@apache.org>]

duncangrant commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664718572



##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/LogBookQueryParams.java
##########
@@ -20,12 +20,28 @@
 
 import java.util.List;
 
+/**
+ * The logbook query parameters.
+ */
 public class LogBookQueryParams {
+
+    /** The number of log items to query. Note, one log item can be a multi-line one, e.g. a stacktrace */
     private Integer numberOfItems;
+
+    /** The indicator whether to return logs in reverse order */
     private Boolean reverseOrder;
+
+    /** The log levels: INFO, FATAL, ERROR, DEBUG or WARNING */
     private List<String> levels;
-    private String initTime;
-    private String finalTime;
+
+    /** The date-time to look log items from */
+    private String dateTimeFrom;

Review comment:
       why isn't this a date?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org