You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/16 07:38:18 UTC
[GitHub] [dolphinscheduler] hongshuboy opened a new issue #8067: [Bug][LogServer] LoggerRequestProcessor incorrect word and improper use of StringBuilder
hongshuboy opened a new issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
**Describe the question:**
`org.apache.dolphinscheduler.server.log.LoggerRequestProcessor#process`
on line 72, it has Dangling Javadoc comment and misspelling the word request
```java
/**
* reuqest task log command type
*/
```
Replace with the following
```java
//request task log command type
```
on line 97, string concatenation as argument to 'StringBuilder.append()' call
```java
for (String line : lines) {
builder.append(line + "\r\n");
}
```
Replace with the following
```java
for (String line : lines) {
builder.append(line).append("\r\n");
}
```
on line 109, type status can be primitive
```java
Boolean status = true;
```
Replace with the following
```java
boolean status = true;
```
`org.apache.dolphinscheduler.server.log.LoggerRequestProcessor#getFileContentBytes`
on line 131, misspelling the word download, and `@throws Exception` is redundant
```java
/**
* get files content bytes，for down load file
*
* @param filePath file path
* @return byte array of file
* @throws Exception exception
*/
```
Replace with the following
```java
/**
* get files content bytes for download file
*
* @param filePath file path
* @return byte array of file
*/
```
### What you expected to happen
Obvious code exception
### How to reproduce
In the latest dev branch
module: dolphinscheduler-log-server
class: org.apache.dolphinscheduler.server.log.LoggerRequestProcessor
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hongshuboy removed a comment on issue #8067: [Bug][LogServer] LoggerRequestProcessor incorrect word and improper use of StringBuilder
Posted by GitBox <gi...@apache.org>.
hongshuboy removed a comment on issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067#issuecomment-1013827374
I want to deal with this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8067: [Bug][LogServer] LoggerRequestProcessor incorrect word and improper use of StringBuilder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067#issuecomment-1013826706
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong closed issue #8067: [Bug][LogServer] LoggerRequestProcessor incorrect word and improper use of StringBuilder
Posted by GitBox <gi...@apache.org>.
zhuangchong closed issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hongshuboy commented on issue #8067: [Bug][LogServer] LoggerRequestProcessor incorrect word and improper use of StringBuilder
Posted by GitBox <gi...@apache.org>.
hongshuboy commented on issue #8067:
URL: https://github.com/apache/dolphinscheduler/issues/8067#issuecomment-1013827374
I want to deal with this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org