You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2010/01/05 17:22:58 UTC

svn commit: r896116 - /myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java

Author: lofwyr
Date: Tue Jan  5 16:22:58 2010
New Revision: 896116

URL: http://svn.apache.org/viewvc?rev=896116&view=rev
Log:
optimize logging

Modified:
    myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java

Modified: myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java?rev=896116&r1=896115&r2=896116&view=diff
==============================================================================
--- myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java (original)
+++ myfaces/tobago/trunk/extension/facelets/src/main/java/org/apache/myfaces/tobago/facelets/GridLayoutConstraintHandler.java Tue Jan  5 16:22:58 2010
@@ -73,7 +73,6 @@
       LayoutBase component = (LayoutBase) parent;
 
       if (parent instanceof LayoutComponent && columnSpan != null) {
-        LOG.error(columnSpan.getValue());
         if (columnSpan.isLiteral()) {
           ((LayoutComponent) component).setColumnSpan(Integer.valueOf(columnSpan.getValue()));
         } else {
@@ -83,7 +82,6 @@
       }
 
       if (parent instanceof LayoutComponent && rowSpan != null) {
-        LOG.error(rowSpan.getValue());
         if (rowSpan.isLiteral()) {
           ((LayoutComponent) component).setRowSpan(Integer.valueOf(rowSpan.getValue()));
         } else {
@@ -93,7 +91,6 @@
       }
 
       if (width != null) {
-        LOG.error(width.getValue());
         if (width.isLiteral()) {
           component.setWidth(Measure.parse(width.getValue()));
         } else {
@@ -103,7 +100,6 @@
       }
 
       if (height != null) {
-        LOG.error(height.getValue());
         if (height.isLiteral()) {
           component.setHeight(Measure.parse(height.getValue()));
         } else {
@@ -113,7 +109,6 @@
       }
 
       if (minimumWidth != null) {
-        LOG.error(minimumWidth.getValue());
         if (minimumWidth.isLiteral()) {
           component.setMinimumWidth(Measure.parse(minimumWidth.getValue()));
         } else {
@@ -123,7 +118,6 @@
       }
 
       if (minimumHeight != null) {
-        LOG.error(minimumHeight.getValue());
         if (minimumHeight.isLiteral()) {
           component.setMinimumHeight(Measure.parse(minimumHeight.getValue()));
         } else {
@@ -133,7 +127,6 @@
       }
 
       if (preferredWidth != null) {
-        LOG.error(preferredWidth.getValue());
         if (preferredWidth.isLiteral()) {
           component.setPreferredWidth(Measure.parse(preferredWidth.getValue()));
         } else {
@@ -143,7 +136,6 @@
       }
 
       if (preferredHeight != null) {
-        LOG.error(preferredHeight.getValue());
         if (preferredHeight.isLiteral()) {
           component.setPreferredHeight(Measure.parse(preferredHeight.getValue()));
         } else {
@@ -153,7 +145,6 @@
       }
 
       if (maximumWidth != null) {
-        LOG.error(maximumWidth.getValue());
         if (maximumWidth.isLiteral()) {
           component.setMaximumWidth(Measure.parse(maximumWidth.getValue()));
         } else {
@@ -163,7 +154,6 @@
       }
 
       if (maximumHeight != null) {
-        LOG.error(maximumHeight.getValue());
         if (maximumHeight.isLiteral()) {
           component.setMaximumHeight(Measure.parse(maximumHeight.getValue()));
         } else {
@@ -172,7 +162,7 @@
         }
       }
     } else {
-      LOG.warn("");
+      LOG.warn("Layout Constraints inside of a non LayoutBase component!");
     }
   }
 }