You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/28 08:11:13 UTC

[GitHub] [skywalking] EvanLjp edited a comment on pull request #5571: inject span tags from correlation

EvanLjp edited a comment on pull request #5571:
URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596


   
   
   > This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context.
   > 
   > Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes.
   
   Do you have any other ideas? This PR comes from support for online flow pressure measurement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org