You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2013/11/06 22:46:35 UTC
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 9:46 p.m.)
Review request for hive and Thejas Nair.
Changes
-------
Changes per last feedback.
Bugs: HIVE-5229
https://issues.apache.org/jira/browse/HIVE-5229
Repository: hive-git
Description
-------
Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
conf/hive-default.xml.template b7234b4
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
Diff: https://reviews.apache.org/r/14719/diff/
Testing
-------
TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
Thanks,
Vaibhav Gumashta
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/#review28351
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 6, 2013, 11:14 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14719/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:14 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5229
> https://issues.apache.org/jira/browse/HIVE-5229
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
> conf/hive-default.xml.template b7234b4
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>
> Diff: https://reviews.apache.org/r/14719/diff/
>
>
> Testing
> -------
>
> TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 4:12 a.m.)
Review request for hive and Thejas Nair.
Changes
-------
Removing the leftover whitespace
Bugs: HIVE-5229
https://issues.apache.org/jira/browse/HIVE-5229
Repository: hive-git
Description
-------
Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
conf/hive-default.xml.template b7234b4
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
Diff: https://reviews.apache.org/r/14719/diff/
Testing
-------
TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
Thanks,
Vaibhav Gumashta
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
> On Nov. 7, 2013, 3:52 a.m., Thejas Nair wrote:
> > conf/hive-default.xml.template, line 1907
> > <https://reviews.apache.org/r/14719/diff/3/?file=380113#file380113line1907>
> >
> > I will take care of this white space before commit.
> >
Sorry, fixed it.
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/#review28350
-----------------------------------------------------------
On Nov. 7, 2013, 4:12 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14719/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 4:12 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5229
> https://issues.apache.org/jira/browse/HIVE-5229
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
> conf/hive-default.xml.template b7234b4
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>
> Diff: https://reviews.apache.org/r/14719/diff/
>
>
> Testing
> -------
>
> TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/#review28350
-----------------------------------------------------------
conf/hive-default.xml.template
<https://reviews.apache.org/r/14719/#comment55182>
I will take care of this white space before commit.
- Thejas Nair
On Nov. 6, 2013, 11:14 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14719/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 11:14 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5229
> https://issues.apache.org/jira/browse/HIVE-5229
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
> conf/hive-default.xml.template b7234b4
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>
> Diff: https://reviews.apache.org/r/14719/diff/
>
>
> Testing
> -------
>
> TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 11:14 p.m.)
Review request for hive and Thejas Nair.
Changes
-------
Adding a configurable wait queue size.
Bugs: HIVE-5229
https://issues.apache.org/jira/browse/HIVE-5229
Repository: hive-git
Description
-------
Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
conf/hive-default.xml.template b7234b4
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
Diff: https://reviews.apache.org/r/14719/diff/
Testing
-------
TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
Thanks,
Vaibhav Gumashta
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/#review28328
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
<https://reviews.apache.org/r/14719/#comment55149>
Can you update the comment about the queue size. Also, what do you think about making this a different configuration ?
- Thejas Nair
On Nov. 6, 2013, 9:46 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14719/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 9:46 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5229
> https://issues.apache.org/jira/browse/HIVE-5229
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
> conf/hive-default.xml.template b7234b4
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>
> Diff: https://reviews.apache.org/r/14719/diff/
>
>
> Testing
> -------
>
> TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 14719: Better thread management for HiveServer2 async
threads
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14719/#review28320
-----------------------------------------------------------
Nice work!! just noting there is some lint issues with whitespace.
conf/hive-default.xml.template
<https://reviews.apache.org/r/14719/#comment55134>
trailing whitespace needs to be removed.
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
<https://reviews.apache.org/r/14719/#comment55133>
this whitespace needs to be cleaned up. Notice the bright red.
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
<https://reviews.apache.org/r/14719/#comment55136>
understand that this is not your whitepsace but since you'll be cleaning up other instances, please clean this one up too
- Brock Noland
On Nov. 6, 2013, 9:46 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14719/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 9:46 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5229
> https://issues.apache.org/jira/browse/HIVE-5229
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Improves the current strategy by not keeping all the async threads alive when there are no corresponding requests. The async threads terminate after a configurable keepalive time if there are no new requests to handle.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b
> conf/hive-default.xml.template b7234b4
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java f6adf92
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62
>
> Diff: https://reviews.apache.org/r/14719/diff/
>
>
> Testing
> -------
>
> TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>