[jira] [Commented] (KAFKA-8417) Remove redundant network definition --net=host when starting testing docker containers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846948#comment-16846948 ] 

ASF GitHub Bot commented on KAFKA-8417:
---------------------------------------

kkonstantine commented on pull request #6797: KAFKA-8417: Remove redundant network definition --net=host when starting testing docker containers
URL: https://github.com/apache/kafka/pull/6797
 
 
   * Remove non-user-defined network --net=host which is redundant when starting system test docker containers
   
   * Tested by running a round of system tests locally and on jenkins
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove redundant network definition --net=host when starting testing docker containers
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-8417
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8417
>             Project: Kafka
>          Issue Type: Bug
>          Components: system tests
>            Reporter: Konstantine Karantasis
>            Assignee: Konstantine Karantasis
>            Priority: Major
>
> The switches {{--net}} and {{--network}} are equivalent in docker, with the latter being preferred. 
> (see [https://github.com/docker/cli/blob/master/cli/command/container/opts.go] where currently there's the comment: _// We allow for both "--net" and "--network", although the latter is the recommended way._)
> However, in recent Docker versions, defining both as follows: 
> {{--net=host --network ducknet}}
> fails with error: 
> {{docker: conflicting options: cannot attach both user-defined and non-user-defined network-modes.}}
> Removing {{--net=host}} and keeping only the user-defined network should fix the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)