You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by alexlehm <gi...@git.apache.org> on 2017/04/02 10:50:12 UTC
[GitHub] storm pull request #2039: fix md formatting for windows storm.local.dir exam...
GitHub user alexlehm opened a pull request:
https://github.com/apache/storm/pull/2039
fix md formatting for windows storm.local.dir example
jekyll needs a newline before the code quotes, while e.g. the markdown preview in atom doesn't
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexlehm/storm doc-correction-config-windows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2039
----
commit 5459995f99e5acbcf273e3b5dd1a02b92439e3e7
Author: alexlehm <al...@gmail.com>
Date: 2017-04-02T10:49:01Z
fix md formatting for windows storm.local.dir example (jekyll needs a newline before the code quotes)
Signed-off-by: alexlehm <al...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2039: fix md formatting for windows storm.local.dir example
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2039
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2039: fix md formatting for windows storm.local.dir example
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2039
Btw I'm OK to adopt whitespace diff. You don't need to modify it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2039: fix md formatting for windows storm.local.dir example
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2039
Thanks @alexlehm I merged into master, 1.x, 1.0.x branches.
I've other works to do so site update will be followed up later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2039: fix md formatting for windows storm.local.dir exam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2039: fix md formatting for windows storm.local.dir exam...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2039#discussion_r109326061
--- Diff: docs/Setting-up-a-Storm-cluster.md ---
@@ -58,11 +58,12 @@ If the port that your Zookeeper cluster uses is different than the default, you
```yaml
storm.local.dir: "/mnt/storm"
```
-If you run storm on windows,it could be:
+If you run storm on windows, it could be:
+
--- End diff --
Actual change would be only this line, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2039: fix md formatting for windows storm.local.dir example
Posted by alexlehm <gi...@git.apache.org>.
Github user alexlehm commented on the issue:
https://github.com/apache/storm/pull/2039
looks like atom has caused a few whitespace diffs since it removes trailing spaces, hope that is ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2039: fix md formatting for windows storm.local.dir exam...
Posted by alexlehm <gi...@git.apache.org>.
Github user alexlehm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2039#discussion_r109349013
--- Diff: docs/Setting-up-a-Storm-cluster.md ---
@@ -58,11 +58,12 @@ If the port that your Zookeeper cluster uses is different than the default, you
```yaml
storm.local.dir: "/mnt/storm"
```
-If you run storm on windows,it could be:
+If you run storm on windows, it could be:
+
--- End diff --
yes (actually the blank line, the other change is only cosmetic)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---