You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/14 23:05:27 UTC

[GitHub] [cordova-plugin-camera] breautek opened a new pull request #677: Revert "fix(android): Declare CAMERA permission"

breautek opened a new pull request #677:
URL: https://github.com/apache/cordova-plugin-camera/pull/677


   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Reverts https://github.com/apache/cordova-plugin-camera/pull/670
   
   The blame is actually not with the plugin, but rather the app. Camera plugin will request camera permissions if the camera permission is declared to support coexisting with other plugins that may need camera permission APIs, but otherwise the plugin does not require the camera permission to be declared and therefore it should not declare itself.
   
   If the app uses a plugin that requires the camera permission, it is up to that plugin to add the camera permission itself.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This reverts commit 140e8861e30164da0861fec548d0aa2413197e12.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Ran `npm test`
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-camera] breautek merged pull request #677: Revert "fix(android): Declare CAMERA permission"

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #677:
URL: https://github.com/apache/cordova-plugin-camera/pull/677


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org