You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/10 17:26:37 UTC

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #19108: Fix race condition in NaiveEngine::PushAsync

ptrendx commented on a change in pull request #19108:
URL: https://github.com/apache/incubator-mxnet/pull/19108#discussion_r486512156



##########
File path: src/engine/naive_engine.cc
##########
@@ -208,8 +210,7 @@ class NaiveEngine final : public Engine {
     for (auto var : mutable_vars) {
       ++var->version_;
     }
-    CHECK(req_completed)
-        << "NaiveEngine only support synchronize Push so far";
+    future.wait();

Review comment:
       With naive engine it does not really make a difference but generally speaking this wait should be before the `version_` increment, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org