[jira] [Commented] (MWRAPPER-67) mvnw script does not download jar if used in git bash in windows

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654191#comment-17654191 ] 

ASF GitHub Bot commented on MWRAPPER-67:
----------------------------------------

hazendaz commented on PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1370262620

   @michael-o Ping, any possibility of this being merged before next release happens?




> mvnw script does not download jar if used in git bash in windows
> ----------------------------------------------------------------
>
>                 Key: MWRAPPER-67
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-67
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.1.1
>            Reporter: Jeremy Landis
>            Priority: Minor
>
> Usage of git bash will not download the maven wrapper jar along with curl (probably others) due to having windows line endings in the URL (trailing).  To ensure that is not the case, make sure to strip invalid line endings out before usage.
> Use case, ./mvnw in powershell will use mvnw.cmd and has no issues downloading.  If user does same in git bash, it will fail with invalid URL error with curl.  Using ./mvnw.cmd there will work but not natural usage.  To ensure this simply just works for full support, trim out invalid line feeds.
> note: This only affected the download.  It worked otherwise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)