You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/11/11 16:03:52 UTC

[GitHub] [logging-log4j2] sandeepbarnwal commented on pull request #436: LOG4J2-2850 Fix ctor used in LocalizedMessageFactory#newMessage().

sandeepbarnwal commented on pull request #436:
URL: https://github.com/apache/logging-log4j2/pull/436#issuecomment-725508202


   > Thanks so much @sandeepbarnwal! Would you mind updating `/src/changes/changes.xml` and adding a simple test (to `LocalizedMessageTest`?) as well, please?
   
   Sure and thanks for correcting the typo in the description. Added the test case in LocalizedMessageFactoryTest as the change in that class.
   
   > Thanks so much @sandeepbarnwal! Would you mind updating `/src/changes/changes.xml` and adding a simple test (to `LocalizedMessageTest`?) as well, please?
   
   Sure. I have added the test cases and also thanks for the correction in the description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org